Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] ANN warnings/tests updates #4101

Merged
merged 2 commits into from
Jul 28, 2021
Merged

[REVIEW] ANN warnings/tests updates #4101

merged 2 commits into from
Jul 28, 2021

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Jul 26, 2021 •
edited
Loading

With the update to FAISS 1.7, the previously observed issue with IVFPQ has disappeared. However some other issues were recently identified in ANN methods. This PR updates the relevant warnings and pytests accordingly.

@viclafargue viclafargue requested a review from a team as a code owner July 26, 2021 17:55
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 26, 2021
@viclafargue viclafargue added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Jul 26, 2021
@dantegd
Copy link
Member

dantegd commented Jul 27, 2021

@viclafargue some nn failures cropped up in this PR that seemed innocuous, would you happen to know why?

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 28, 2021
@viclafargue
Copy link
Contributor Author

@viclafargue some nn failures cropped up in this PR that seemed innocuous, would you happen to know why?

Yes, the acceptable sets of values for bitsPerCode_ has evolved with FAISS 1.7 update. The cuML code for automatic deduction of the parameters has been updated accordingly. However, it looks like some testing for ivfpq was kept disabled and one of the test wasn't updated according to FAISS update.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@40af8af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4101   +/-   ##
===============================================
  Coverage                ?   85.74%           
===============================================
  Files                   ?      231           
  Lines                   ?    18138           
  Branches                ?        0           
===============================================
  Hits                    ?    15553           
  Misses                  ?     2585           
  Partials                ?        0
Flag Coverage Δ
dask 47.84% <0.00%> (?)
non-dask 78.16% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40af8af...b892937. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jul 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 697df34 into rapidsai:branch-21.08 Jul 28, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
ANN warnings/tests updates (rapidsai#4101)
f6d9395 
With the update to FAISS 1.7, the [previously observed issue with IVFPQ](rapidsai#3318) has disappeared. However some other issues were recently identified in ANN methods. This PR updates the relevant warnings and pytests accordingly.

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viclafargue @dantegd @codecov-commenter